[services] Add cloudprofile.agent role to service accounts in terraform #13978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-goldstein
previously requested changes
Nov 7, 2023
infra/gcp-broad/main.tf
Outdated
| @@ -507,7 +510,10 @@ resource "google_storage_bucket_iam_member" "testns_batch_bucket_admin" { | |||
| module "ci_gsa_secret" { | |||
| source = "./gsa" | |||
| name = "ci" | |||
| project = var.gcp_project | |||
| project = var.gcp_project, | |||
There was a problem hiding this comment.
Suggested change
| project = var.gcp_project, | |
| project = var.gcp_project |
infra/gcp/main.tf
Outdated
| @@ -487,13 +490,19 @@ resource "google_storage_bucket_iam_member" "testns_batch_bucket_admin" { | |||
| module "ci_gsa_secret" { | |||
| source = "./gsa_k8s_secret" | |||
| name = "ci" | |||
| project = var.gcp_project | |||
| project = var.gcp_project, | |||
There was a problem hiding this comment.
Suggested change
| project = var.gcp_project, | |
| project = var.gcp_project |
infra/gcp/main.tf
Outdated
| } | ||
|
|
||
| module "testns_ci_gsa_secret" { | ||
| source = "./gsa_k8s_secret" | ||
| name = "testns-ci" | ||
| project = var.gcp_project | ||
| project = var.gcp_project, |
There was a problem hiding this comment.
Suggested change
| project = var.gcp_project, | |
| project = var.gcp_project |
infra/gcp-broad/main.tf
Outdated
| @@ -458,6 +458,7 @@ module "auth_gsa_secret" { | |||
| iam_roles = [ | |||
| "iam.serviceAccountAdmin", | |||
| "iam.serviceAccountKeyAdmin", | |||
| "cloudprofile.agent" | |||
There was a problem hiding this comment.
This also needs to be on the test auth account, right?
|
I'm not sure how to apply it anymore. Can we do it together on zoom at some point this week? |
|
Sure thing! Maybe thursday afternoon at some point? Feel free to grab something on my calendar. |
daniel-goldstein
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.